[ignition-msgs*] Fix flaky CI tests for ignition-msgs* ports#14464
[ignition-msgs*] Fix flaky CI tests for ignition-msgs* ports#14464traversaro wants to merge 3 commits intomicrosoft:masterfrom
Conversation
We fix the flaky CI tests by not adding anymore the bin and debug/bin directories to the PATH, but rather by making sure that VCPKG_APPLOCAL_DEPS option is correctly propagated.
|
As I needed to modify the |
|
Nicole's PR #14399 also tried to fix this issue. |
To clarify, this is a cleanup that should avoid problems of this kind also in the future. |
|
The osgearth failure is due to this error: It does not seem to be directly related to this modification. I started #14474 to check if the ports fails also in the current master. |
JackBoosY
added
the
category:port-bug
Unfortunately #14474 worked fine, so either the osqearth failure is non-deterministic, or it is actually related to the change of the PR. Another possibility is that the failure is due to the rebuild of one of osgeart dependencies. |
|
osgearth has also been sporadically failing; I suspect they have some form of races in their build. As such I don't think we should block merging over that. However, I have a concern with forcing |
command: Include dirs: And some warnings: |
That is the reason why it is enabled only for ignition-msgs* ports and not for all the ports. |
BillyONeal
left a comment
BillyONeal
left a comment
There was a problem hiding this comment.
That is the reason why it is enabled only for ignition-msgs* ports and not for all the ports.
Ah, derp, I somehow read the default you set as backwards to what you actually set 🤣
BillyONeal
added
the
info:needs-maintainer-attention
No problem. I think that in general having an opt-in |
|
I'll merge after CI runs through. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
isn't that why ADD_BIN_TO_PATH exists? |
Good catch! Yes, I think that would also be sufficient, and will not require the crazy luck of being able to do a full re-build of all the cmake-based ports without any spurious failures, that is apparently really unlikely. I think I can use that one. Given that the path is modified only during the build phase, this should also avoid all the problems of finding the clang as the compiler during the configure phase. |
strega-nil
removed
the
info:needs-maintainer-attention
|
Waiting for the |
Done in #14730 . |
5 participants
We fix the flaky CI tests by not adding anymore the bin and debug/bin directories to the
PATH, but rather by making sure thatVCPKG_APPLOCAL_DEPSoption is correctly propagated.Describe the pull request
What does your PR fix? Fixes the problem mentioned in [ignition] Updates on various pkgs 🤖 #14324 (comment), not sure if there is a corresponding issue.
Which triplets are supported/not supported? Have you updated the CI baseline? The PR should not change the supported triplets.
Does your PR follow the maintainer guide? Yes
cc @BillyONeal